ci(travis): utilize stages and add Android and iOS builds #1176
Conversation
hypery2k
commented
Jan 29, 2018
hypery2k
commented
- Added native android build
- Added iOS build in Travis
- Utilize stages
* Added native android build * Added iOS build in Travis * Utilize stages
ghost
added
the
|
@sis0k0 Any chance to get it merged? |
|
Great job, @hypery2k! I have only one concern, but I may be wrong. I think the building of the tests app is missing. It's removed from the config (https://github.com/NativeScript/nativescript-angular/pull/1176/files#diff-354f30a63fb0907d4ad57269548329e3L47) and I don't see it in the updated version. Is that intentional? |
|
no it wasn't, just by accident |
.travis.yml
Outdated
| - android-wait-for-emulator | ||
| - adb shell input keyevent 82 & | ||
| script: | ||
| - tns build android |
There was a problem hiding this comment.
I think this should be the last step (after navigating to tests and running npm install)
There was a problem hiding this comment.
@sis0k0 the adb shell or the build?
* test on nodejs 6 and 8 * build angular and test project
|
@sis0k0 Could you trigger your jenkins ci build, also? |
| @@ -1,6 +1,12 @@ | |||
| { | |||
| "nativescript": { | |||
| "id": "org.nativescript.ngtests" | |||
| "id": "org.nativescript.ngtests", | |||
| "tns-ios": { | |||
There was a problem hiding this comment.
Can you remove the platforms here?
There was a problem hiding this comment.
no, because than tns build will fail with version of undefined errors
There was a problem hiding this comment.
Ok, change the versions to 'next' then :)
sis0k0
changed the title
|
thanks ;) |
